[WIP] Reduce number of allocations in histogram metric#317
Open
simpl1g wants to merge 1 commit intoprometheus:mainfrom
Open
[WIP] Reduce number of allocations in histogram metric#317simpl1g wants to merge 1 commit intoprometheus:mainfrom
simpl1g wants to merge 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Konstantin Ilchenko <[email protected]>
758ebc8 to
18d156c
Compare
Contributor
Author
|
I will also remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dmagliola Hi. I'm committing this as WIP so you can compare old and new implementations side by side, maybe you can add some test cases for benchmarks to find problems. If you are ok with changes I will clean up everything. All tests are passing without modifications, I guess nothing will change in logic it self. I haven't touched
#getmethod though, where is it used?You can find bench results at the end of
spec/benchmarks/histogram.rbfile. There are some improvements, but I'm not really happy with results. I believe storage should be changed a bit. Current way of storing each:leas separate hash requires a lot of manipulations for#values. Having single hash can be more beneficial, but current store interface does not allow do this.Instead of
something like this should be easier to operate